Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stricter npm field validation #484

Merged
merged 13 commits into from
Nov 19, 2023
Merged

Stricter npm field validation #484

merged 13 commits into from
Nov 19, 2023

Conversation

lachlancollins
Copy link
Collaborator

@lachlancollins lachlancollins commented Nov 12, 2023 •
edited
Loading

Changes:

  • Makes npm field required and uses stricter regex (package-name-regex)
  • Fixed properties for 5 entries in components.json
  • Moved 1 entry from components.json to templates.json
  • Removed 1 entry from components.json that does not have a published npm package

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2023 •
edited
Loading

✅ Deploy Preview for sveltesociety-preview ready!

Name Link
🔨 Latest commit 0c9a44b
🔍 Latest deploy log https://app.netlify.com/sites/sveltesociety-preview/deploys/6553f989c7094a0008c978f8
😎 Deploy Preview https://deploy-preview-484--sveltesociety-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MacFJA MacFJA added the need rebase The PR need to be rebased label Nov 12, 2023
@lachlancollins lachlancollins changed the title Stricter npm and repository schema validation Stricter npm and repository field validation Nov 12, 2023
@lachlancollins lachlancollins marked this pull request as ready for review November 12, 2023 11:59
@MacFJA MacFJA removed the need rebase The PR need to be rebased label Nov 12, 2023
MacFJA
MacFJA reviewed Nov 12, 2023
View reviewed changes
src/lib/schemas.js Outdated Show resolved Hide resolved
src/lib/schemas.js Outdated Show resolved Hide resolved
src/routes/components/components.json Show resolved Hide resolved
src/routes/components/components.json Show resolved Hide resolved
@lachlancollins lachlancollins changed the title Stricter npm and repository field validation Stricter npm field validation Nov 12, 2023
@lachlancollins
Copy link
Collaborator Author

Hi @MacFJA , just checking if you wanted any further changes? Thanks!

@MacFJA MacFJA merged commit f3c9859 into svelte-society:main Nov 19, 2023
4 checks passed
@lachlancollins lachlancollins deleted the require-npm-field branch November 19, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MacFJA MacFJA MacFJA left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlancollins @MacFJA